wasm: add wasmEdge container process to cgroup #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Burning1020
requested changes
Sep 8, 2023
| @@ -263,9 +276,7 @@ impl ProcessLifecycle<ExecProcess> for WasmEdgeExecLifecycle { | |||
| } | |||
|
|
|||
| async fn delete(&self, _p: &mut ExecProcess) -> containerd_shim::Result<()> { | |||
| Err(Error::Unimplemented( | |||
There was a problem hiding this comment.
Exec in wasm container is still not supported, so should return Err here.
wasm/src/utils.rs
Outdated
| @@ -75,3 +76,23 @@ pub fn get_memory_limit(spec: &Spec) -> Option<i64> { | |||
| .and_then(|x| x.memory().as_ref()) | |||
| .and_then(|x| x.limit()) | |||
| } | |||
|
|
|||
| pub(crate) fn get_rootfs(spec: &Spec) -> containerd_shim::Result<String> { | |||
There was a problem hiding this comment.
Better to return Option, let the caller decide how to handle None
abel-von
reviewed
Sep 8, 2023
| "rootfs is not set in runtime spec".to_string(), | ||
| ))? | ||
| .path(); | ||
| mkdir(rootfs, 0o711).await?; |
There was a problem hiding this comment.
why is this mkdir removed?
There was a problem hiding this comment.
Sorry, will update later
Burning1020
force-pushed
the
add-cgroup
branch
from
a75f4e6
to
f41467d
Compare
Signed-off-by: Poorunga <2744323@qq.com>
Burning1020
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wasmEdge container process to cgroup, follow up #74